Reported series winner sometimes incorrect after overtime.

[dechristopher]

No idea how this can be replicated, but in numerous matches played with this plugin, the reported winner of the series in chat has been the wrong team. This usually happened to us after an overtime win but additionally happened a single time after a normal length game with no overtime.

[splewis]

Are you seeing this in single-map matches or multiple-map matches?

If it's the 1st it should be much easier to debug.

[dechristopher]

It's happening on single-map matches. No idea what the results of a multi-map series would be because we haven't tested them.

[splewis]

I was unable to reproduce it, but I've made some changes that may fix this.

My suspicion is that the round_end event could have been firing after cs_win_panel_match, meaning if:

• team 1 wins a round, score becomes 10-15 from 9-15
• team 2 wins the last round, score becomes 10-16

the "last round winner" would be the wrong team, which is how the cs_win_panel_match callback determined the winner before.

I would imagine this could happen in anywhere up to 50% of cases. Since there is some degree of momentum to the game, it was more likely around 25%.

[techlover1]

This issue is still present http://i.imgur.com/dy2G6oD.jpg

[splewis]

@techlover1 can you give a version or commit that the servers was running in that screenshot?

[techlover1]

@splewis version 0.0.1-dev+79

[splewis]

I believe I've fixed this issue in 00e87bb now.

The issue was overtime-halftime side swaps not being done, which should work now.

[dechristopher]

@splewis that's great to hear. Thanks for looking deeper into this.

[techlover1]

@splewis awesome! I'll be updating everything tomorrow