Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Force kick after get5_endmatch #984

Closed
2 tasks done
LowArte opened this issue Feb 18, 2023 · 9 comments · Fixed by #985
Closed
2 tasks done

[Feature Request]: Force kick after get5_endmatch #984

LowArte opened this issue Feb 18, 2023 · 9 comments · Fixed by #985

Comments

@LowArte
Copy link

LowArte commented Feb 18, 2023

Prereleases & Documentation

Get5 Version

0.12.1

The Feature

I need to force kick players after get5_endmatch. I need to write my own plugin to do this ?

@nickdnk
Copy link
Collaborator

nickdnk commented Feb 18, 2023

You can just do get5_endmatch;kick @all in that case.

@LowArte
Copy link
Author

LowArte commented Feb 18, 2023

Thanks for answer. I try, but get error

photo_2023-02-18_14-03-08

@nickdnk
Copy link
Collaborator

nickdnk commented Feb 18, 2023

You may need the basecommands.smx plug-in from SourceMod enabled for it to work. See https://wiki.alliedmods.net/Admin_commands_(sourcemod).

@LowArte
Copy link
Author

LowArte commented Feb 18, 2023

Thanks sm_kick worked for me. But I need localization for kick message. So I do modification of Get5MapResultEvent, and use Get5_OnMapResult to handle it. Close Issue. Thanks.

@LowArte LowArte closed this as completed Feb 18, 2023
@nickdnk
Copy link
Collaborator

nickdnk commented Feb 18, 2023

Note that you will have to update custom localizations each time you update the plug-in, as we change the strings often. Why do you need localization if players are being kicked? They won't see the message. The message shown after being kicked is already localized.

Edit: Ah, there is of course no message like this if you manually kick people. I didn't think of that. We could perhaps make it an option to kick players when using the get5_endmatch to get the best of both worlds.

@LowArte
Copy link
Author

LowArte commented Feb 18, 2023

If you can do that will be good. I think you can add one more argument to do it

@nickdnk
Copy link
Collaborator

nickdnk commented Feb 18, 2023

We don't really have a consistent way of providing boolean arguments to commands, so I think I'll just add a Cvar you can change which will change the behavior of the command.

@LowArte
Copy link
Author

LowArte commented Feb 18, 2023

Okey. I waiting. Reopen Issue

@nickdnk
Copy link
Collaborator

nickdnk commented Feb 18, 2023

Available in 0.13: https://github.com/splewis/get5/releases/tag/v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants