Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] render exclusive write arrows #381

Closed

Conversation

uforic
Copy link

@uforic uforic commented Jan 16, 2023

Description

I noticed that exclusive write arrows weren't being rendered when using the render_dot_tree function.

In the code that adds edges, we check reads and writes, but not exclusive writes.

Adding exclusive writes fixed the issue.

Open questions

  • What color should exclusive writes be? Read is green, write is blue. Any other visual differences we'd prefer?
  • Per the contribution guide, I was hoping to add labels to this PR, but don't seem to have permissions. Anything I'm doing wrong here?

@stonier
Copy link
Member

stonier commented Jan 22, 2023

Set the color to deepskyblue and incidentally, found and fixed a bug with rendering off-the-grid blackboard clients.

Changes added in #383.

Thanks!

Also removed the reference to labels in CONTRIBUTING.md. Did not realise those without write access could not edit the labels. Thanks for the catch.

@stonier stonier closed this Jan 22, 2023
@stonier stonier added this to the 2.2 / Humble milestone Jan 22, 2023
@stonier stonier self-assigned this Jan 22, 2023
@stonier stonier self-requested a review January 22, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants