Plugins can send usage data #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $data; | ||
| } | ||
|
|
||
| private function _add_plugin_usage_data(&$data){ |
|
I think the event name is not adhering to our naming scheme https://www.dokuwiki.org/devel:events_list#naming_structure. Though I am not 100% sure we have one for plugins. PLUGIN_POPULARITY_DATA_SETUP maybe? |
They just need to register to the PLUGIN_USAGE_DATA event, and then to add
either a simple string, or an array of key / value. For example:
function register(Doku_Event_Handler $controller) {
$controller->register_hook('PLUGIN_USAGE_DATA', 'AFTER', $this, 'usage_data');
}
function usage_data(&$event){
$event->data['my_plugin_name'] = 'my usage data';
//or: $event->data['my_plugin_name'] = array ('k1' => 'v1', 'k2' => 'v2');
}
gturri
force-pushed
the
autosubmit_plugin3
branch
from
ce02cbe
to
5875e53
Compare
|
Thanks for this feedback. Here is an update. |
splitbrain
added a commit
that referenced
this pull request
May 27, 2015
Plugins can send usage data
|
The inspection completed: 1 updated code elements |
|
Thanks! I just documented this feature on https://www.dokuwiki.org/devel:plugin_programming_tips#sending_popularity_data |
|
Can you document the event also at https://www.dokuwiki.org/devel:event:PLUGIN_POPULARITY_DATA_SETUP |
|
Done |
gturri
added a commit
to gturri/nspages
that referenced
this pull request
May 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They just need to register to the PLUGIN_USAGE_DATA event, and then to add
either a simple string, or an array of key / value. For example: