Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize jQuery UI date picker FS#2912 #503

Merged
merged 2 commits into from
Feb 2, 2014
Merged

Conversation

splitbrain
Copy link
Collaborator

This should set the datepicker to the configured language. @Klap-in could you check if it works for FS#2912?

@Klap-in
Copy link
Collaborator

Klap-in commented Jan 17, 2014

Works nice!

Minor observation: when switching between other languages than English, it switch directly. When switching to English you need to re-save the config another time before the datapicker will be translated. (browser caches purged at every change with Ctrl + F5)

@splitbrain
Copy link
Collaborator Author

@Klap-in that's weird. It might be a caching issue but the cache depends on the config file which gets changed when you change the language. How exactly did you test this?

@Klap-in
Copy link
Collaborator

Klap-in commented Jan 19, 2014

  • save the config to reset caching.
  • check a bureaucracy page with form field date so with datepicker
  • change in config language to Dutch
  • check page, see that it is still english
  • save the config
  • now it is Dutch in datepicker
  • change to pt-br was directly changed after config change to pt-br.

@Chris--S
Copy link
Collaborator

Chris--S commented Feb 2, 2014

👍

splitbrain added a commit that referenced this pull request Feb 2, 2014
localize jQuery UI date picker FS#2912
@splitbrain splitbrain merged commit 69736a1 into master Feb 2, 2014
@splitbrain splitbrain deleted the datepickerlocale branch February 2, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants