-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ujson version #389
fix ujson version #389
Conversation
You might also need to update the ujson package that's being downloaded in the Makefile: https://github.com/splunk/eventgen/blob/develop/Makefile#L45 |
606f6dd
to
2aa781b
Compare
@@ -42,7 +42,7 @@ test_helper: | |||
docker exec -i ${EVENTGEN_TEST_IMAGE} /bin/sh -c "cd $(shell pwd); pip3 install dist/splunk_eventgen*.tar.gz" | |||
|
|||
@echo 'Installing test requirements' | |||
docker exec -i ${EVENTGEN_TEST_IMAGE} /bin/sh -c "pip3 install --upgrade pip;pip3 install -r $(shell pwd)/requirements.txt;pip3 install git+https://github.com/esnme/ultrajson.git" | |||
docker exec -i ${EVENTGEN_TEST_IMAGE} /bin/sh -c "pip3 install --upgrade pip;pip3 install -r $(shell pwd)/requirements.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check related bug here: ultrajson/ultrajson#326. This issue has been fixed in version 2.0+. So we do not need to use git+https://github.com/esnme/ultrajson.git
to install ujson
.
pip2 install filelock twisted requests queuelib ujson psutil crochet msgpack-python unidecode attrdict service_identity && \ | ||
pip2 install git+https://github.com/esnme/ultrajson.git | ||
pip2 install filelock twisted requests queuelib psutil crochet msgpack-python unidecode attrdict service_identity && \ | ||
pip2 install git+https://github.com/esnme/ultrajson.git@v1.35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conductor2
depends on ujson < 2.0
, so we need to install it in this way.
@@ -10,12 +10,11 @@ pytest-mock>=1.10.4 | |||
boto3 | |||
requests>=2.18.4 | |||
requests[security] | |||
ujson>=1.35 | |||
ujson==2.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade to the latest version 2.0.3.
@@ -9,4 +9,4 @@ exclude = ''' | |||
| build | |||
| dist | |||
)/ | |||
``` | |||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo and bug: #387
No description provided.