-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ujson import error on alpine 3.9 #326
Comments
pip install git+git://github.com/esnme/ultrajson.git but there should really be a new release cut. |
the wheel contains only the lib built against glibc not against musl libc and this messes up the pip install. indeed cloning the repo and running |
what i meant to say is really, that a new release will not fix this. the wheels need to be fixed so that they also contain binaries built against musl libc. |
Notice that the pip output shows that it is using I was able to successfully install ujson from the current master branch after installing a couple more build dependencies:
So the issue seems to be fixed on master. |
when you pip install from git, then there is no wheel, and instead it builds the c dependency. the problem is not in the source on master, but the problem is in the pip wheel package, which is built without musl support. so it is not fixed on master, as it cannot be fixed there, there's nothing wrong on master. the problem is with the pip package. |
@stef As I explained in my previous comment, the problem has nothing to do with wheels, as pip is installing from source in both cases. To confirm this, I added the
|
to quote your original report:
it says "setup.py install" and then it says that the lib you supposedly built on alpine has a glibc dependency. that is impossible, if indeed setup.py install built this on alpine. that missing symbol comes from the badly build wheel. |
I see the same issue (with slightly different output) when I clone the repository, check out the
|
This can be fixed by adding the |
This was fixed on master with #238 |
The root cause was a change to C99 |
good job ;) |
Is a new release going to be cut for this? |
ujson v1.35 can't work vs Alpine 3.9 [1]. upper-constraints are overriden to include the patch needed [2]. It fixes rally testcases (gnocchi). [1] ultrajson/ultrajson#326 [2] ultrajson/ultrajson@d25e024 Change-Id: Iac9975b0669d5975c63d76ddefb64058e5183369 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
ujson v1.35 can't work vs Alpine 3.9 [1]. upper-constraints are overriden to include the patch needed [2]. It fixes rally testcases (gnocchi). [1] ultrajson/ultrajson#326 [2] ultrajson/ultrajson@d25e024 Change-Id: Iac9975b0669d5975c63d76ddefb64058e5183369 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> (cherry picked from commit c6eb6ec)
ujson v1.35 can't work vs Alpine 3.9 [1]. upper-constraints are overriden to include the patch needed [2]. It fixes rally testcases (gnocchi). [1] ultrajson/ultrajson#326 [2] ultrajson/ultrajson@d25e024 Change-Id: Iac9975b0669d5975c63d76ddefb64058e5183369 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> (cherry picked from commit c6eb6ec)
Speedup docker release images build with targeted builds See merge request noc/noc!2358 (cherry picked from commit 5da383d) 2db26a6 define environmets 19d9bc7 Merge branch 'master' of code.getnoc.com:noc/noc 716aee0 Add mongo-rs healthcheck. launch migrations on hc. Remove all other definitions except used 03b2699 Merge 36a3ab1 Merge branch 'master' of code.getnoc.com:noc/noc ebbf12f Merge branch 'master' of code.getnoc.com:noc/noc 0571089 Merge branch 'master' of code.getnoc.com:noc/noc 463e39d Merge branch 'master' of code.getnoc.com:noc/noc efcb50a Speedup docker release images build with targeted builds 553e4b3 Revert to alpine 3.8. Because of ultrajson/ultrajson#326
Get rid of it using the python image based on alpine. I was trying to install python 3.7.3 in the vanilla alpine10 and was facing this problem. I created a new one with the 3.7.3-alpine3.10 tag from https://hub.docker.com/_/python |
@rmacian Interesting. It seems that the alpine package for python has different compiler flags than those used by the python docker image. Alpine 3.10 python:
Python docker image:
If you add |
much appreciated |
working solution: pip install git+git://github.com/esnme/ultrajson.git@6cf6c7f |
After installing ujson in alpine 3.9, Python raises an
ImportError
when attempting to import the package:Possibly related to #180 as the symptoms are similar.
Full terminal output showing steps to reproduce:
The text was updated successfully, but these errors were encountered: