feat: enrich data with linked tables #101
Conversation
- initial commit
- sanitizers (formatting)
- sanitizers (formatting, again)
- sanitizers: json files cannot have comments, however our sanitizer wants our json files to have comments. We changed json to jsoncomment in order to add those required comments.
- sanitizers: json files cannot have comments, however our sanitizer wants our json files to have comments. We changed json to jsoncomment in order to add those required comments (part #2)
- sanitizers: json files cannot have comments, however our sanitizer wants our json files to have comments. We changed json to jsoncomment in order to add those required comments (part #3)
- added integration code: now, we can extract fields, based on the configuration file we have
- some lint sort error
- added support for basic mongo operations and enricher
…r-snmp-poller into feature/integrate-mongo
…ing additional dimensions to walk data
Codecov Report
@@ Coverage Diff @@
## develop #101 +/- ##
===========================================
+ Coverage 52.19% 55.10% +2.90%
===========================================
Files 28 29 +1
Lines 1071 1254 +183
===========================================
+ Hits 559 691 +132
- Misses 512 563 +51
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 217 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 40 | 4 | 173 | 0 |
Click to see the invalid file list
- tests/mib_walk_data/if_mib_walk.json
- tests/mib_walk_data/if_mib_walk_invalid_indexes.json
- tests/mib_walk_data/if_mib_walk_invalid_networks.json
- tests/test_mib_enricher.py
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…r-snmp-poller into feature/integrate-mongo � Conflicts: � splunk_connect_for_snmp_poller/manager/realtime/interface_mib.py � splunk_connect_for_snmp_poller/manager/static/interface_mib_utililities.py � splunk_connect_for_snmp_poller/manager/static/mib_enricher.py � splunk_connect_for_snmp_poller/mongo.py � tests/test_mib_enricher.py � tests/test_static_config_data_for_network_interfaces.py
…ature/integrate-mongo
| mib_enricher.process_one(metric_result) | ||
| for field_name in mib_enricher.dimensions_fields: | ||
| if field_name in metric_result: | ||
| non_metric_result += f'{field_name}="{metric_result[field_name]}" ' |
There was a problem hiding this comment.
If we want to have field names separated by space we append it at the end of each iteration and rely on variables_binds["non_metric"] to have trailing space (most probbably added by MIB server). When there are no dimensions_fields we will have trailing space on the output. Not sure if this is a problem though.
There was a problem hiding this comment.
This is the default way text data is being returned from mib server. I'm not sure if it's correct, but after this PR nothing will be changed.
splunk_connect_for_snmp_poller/manager/realtime/interface_mib.py
Outdated
Show resolved
Hide resolved
|
Expected release notes (by @omrozowicz-splunk) features: fixes: others (will not be included in Semantic-Release notes):
|
|
🎉 This PR is included in version 1.5.0-develop.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR contains implementation of "Enrich data with linked tables" Epic:
`enricher:
oidFamily:
IF-MIB:
"MIB-STATIC-DATA" : { "IF-MIB" : [ { "interface_index" : [ "1", "2" ] }, { "interface_desc" : [ "lo", "eth0" ] }