Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error when an animation channel's target has no node field #46

Closed
Cyphall opened this issue Feb 6, 2024 · 1 comment
Closed
Labels
bug Something isn't working done Everything has been addressed

Comments

@Cyphall
Copy link
Contributor

Cyphall commented Feb 6, 2024

When trying to load a glTF file containing an animation channel with no node field, the parser fails with the error "The glTF is either missing something or has invalid data.".

According to the specs, a channel which does not contain a "node" property is perfectly valid and an implementation should ignore it, unless an extension defines the animated object and the implementation supports this extension.

The nodeIndex member of the AnimationChannel structure should probably be turned into an Optional like other optional properties.

@spnda spnda closed this as completed in 4bbb39f Feb 6, 2024
@spnda spnda added bug Something isn't working done Everything has been addressed labels Feb 6, 2024
@spnda
Copy link
Owner

spnda commented Feb 6, 2024

Thanks for reporting. I've fixed this in the linked commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Everything has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants