Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of Groovy dependencies to just groovy.jar #1109

Merged
merged 2 commits into from Mar 9, 2020

Conversation

szpak
Copy link
Member

@szpak szpak commented Mar 5, 2020

Spock shouldn't provide the other to do not pollute the classpath.
It's common practice nowadays to exclude transitive dependencies,
which is not good as "spock-groovy2-compat" is needed with Groovy 2.

Proposed realase notes entry:

=== Breaking Changes

==== Reduce number of transitive Groovy dependencies to just groovy.jar

Spock started to provide only one Groovy dependency - `groovy.jar`. The others,
in the majority of cases were not needed in the end projects and were only polluting classpath
(or excluded explicitly). If other Groovy dependencies are needed in the project,
they have to be provided explicitly.

This change is Reviewable

Spock shouldn't provide the other to do not pollute the classpath.
It's common practice nowadays to exclude transitive dependencies,
which is not good as "spock-groovy2-compat" is needed with Groovy 2.
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1109   +/-   ##
=========================================
  Coverage     74.24%   74.24%           
  Complexity     3472     3472           
=========================================
  Files           385      385           
  Lines         10661    10661           
  Branches       1309     1309           
=========================================
  Hits           7915     7915           
  Misses         2285     2285           
  Partials        461      461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4796084...3472375. Read the comment docs.

@Vampire
Copy link
Member

Vampire commented Mar 5, 2020

-has +have in the release notes

build.gradle Outdated Show resolved Hide resolved
@szpak szpak requested review from leonard84 and Vampire Mar 6, 2020
build.gradle Outdated Show resolved Hide resolved
spock-spring/boot-test/boot-test.gradle Outdated Show resolved Hide resolved
End projects which need that dependency, should declare
it explicitly.
@szpak szpak force-pushed the szpak/reduceGroovyDeps branch from 32bc516 to 3472375 Compare Mar 8, 2020
Vampire
Vampire approved these changes Mar 8, 2020
Copy link
Member

@Vampire Vampire left a comment

lgtm

@leonard84 leonard84 merged commit 875dad9 into master Mar 9, 2020
5 checks passed
@szpak szpak deleted the szpak/reduceGroovyDeps branch Mar 9, 2020
sthagen added a commit to sthagen/spockframework-spock that referenced this issue Mar 9, 2020
Reduce number of Groovy dependencies to just groovy.jar (spockframework#1109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants