-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of Groovy dependencies to just groovy.jar #1109
Conversation
Spock shouldn't provide the other to do not pollute the classpath. It's common practice nowadays to exclude transitive dependencies, which is not good as "spock-groovy2-compat" is needed with Groovy 2.
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
Coverage 74.24% 74.24%
Complexity 3472 3472
=========================================
Files 385 385
Lines 10661 10661
Branches 1309 1309
=========================================
Hits 7915 7915
Misses 2285 2285
Partials 461 461 Continue to review full report at Codecov.
|
-has +have in the release notes |
End projects which need that dependency, should declare it explicitly.
32bc516
to
3472375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Spock shouldn't provide the other to do not pollute the classpath.
It's common practice nowadays to exclude transitive dependencies,
which is not good as "spock-groovy2-compat" is needed with Groovy 2.
Proposed
realase notes
entry:This change is