Reduce number of Groovy dependencies to just groovy.jar#1109
Merged
Conversation
Spock shouldn't provide the other to do not pollute the classpath. It's common practice nowadays to exclude transitive dependencies, which is not good as "spock-groovy2-compat" is needed with Groovy 2.
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
Coverage 74.24% 74.24%
Complexity 3472 3472
=========================================
Files 385 385
Lines 10661 10661
Branches 1309 1309
=========================================
Hits 7915 7915
Misses 2285 2285
Partials 461 461Continue to review full report at Codecov.
|
Member
|
-has +have in the release notes |
leonard84
reviewed
Mar 5, 2020
Vampire
requested changes
Mar 8, 2020
End projects which need that dependency, should declare it explicitly.
32bc516 to
3472375
Compare
leonard84
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spock shouldn't provide the other to do not pollute the classpath.
It's common practice nowadays to exclude transitive dependencies,
which is not good as "spock-groovy2-compat" is needed with Groovy 2.
Proposed
realase notesentry:This change is