Use Toolchains and Java 17

[leonard84]

No description provided.

[codecov]

Codecov Report

Merging #1366 (d68aac1) into master (9042787) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1366      +/-   ##
============================================
- Coverage     79.33%   79.31%   -0.03%     
  Complexity     3964     3964              
============================================
  Files           403      403              
  Lines         12320    12298      -22     
  Branches       1627     1620       -7     
============================================
- Hits           9774     9754      -20     
+ Misses         1962     1960       -2     
  Partials        584      584              

Impacted Files	Coverage Δ
.../spockframework/builder/CollectionSlotFactory.java	87.50% <0.00%> (-1.39%)	⬇️
...pockframework/mock/runtime/InteractionBuilder.java	86.95% <0.00%> (-0.55%)	⬇️
.../java/org/spockframework/runtime/SpockRuntime.java	70.78% <0.00%> (-0.33%)	⬇️
...n/java/org/spockframework/util/ReflectionUtil.java	80.35% <0.00%> (-0.18%)	⬇️
...spockframework/runtime/ExpressionInfoRenderer.java	92.72% <0.00%> (-0.13%)	⬇️
...k/runtime/FailedSetEqualityComparisonRenderer.java	96.42% <0.00%> (-0.13%)	⬇️
...org/spockframework/compiler/ConditionRewriter.java	92.12% <0.00%> (-0.12%)	⬇️
...org/spockframework/compiler/SpecialMethodCall.java	93.13% <0.00%> (-0.07%)	⬇️
...in/java/org/spockframework/runtime/RunContext.java	96.47% <0.00%> (-0.05%)	⬇️
...rg/spockframework/compiler/WhereBlockRewriter.java	94.01% <0.00%> (-0.04%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9042787...d68aac1. Read the comment docs.

[szpak]

Groovy 2.5 doesn't seem to support Java 16. You should probably exclude those builds.

https://github.com/spockframework/spock/pull/1366/checks?check_run_id=3285269121#step:9:563

[kriegaex]

I would not exclude, but configure to compile to a lower target. Running the build on a recent JDK is still important, IMO.

[szpak]

You might be right. Groovy 2.5 might be able to be executed with Java 16, but with lower target version (but I haven't tested it).

[kriegaex]

I upgraded my Spock playground project, and indeed it is working, despite a few compiler quirks in Groovy-Eclipse which forced me to refactor two classes. Also IntelliJ IDEA is bitching around now. But I got it compiling in Maven. Please also refer to

• Problems with static inner classes and static imports groovy/groovy-eclipse#1292
• https://youtrack.jetbrains.com/issue/IDEA-275889

But in general, it should work.

[leonard84]

Seems like Java 17 is only supported by Groovy 4.x

[szpak]

Seems like Java 17 is only supported by Groovy 4.x

Do you mean by a runtime JDK? I was building today one of my projects with Gradle 7.2, OpenJDK 17 and Spock 2.0 with Groovy 3.0.9 (in fact with 3.0.8 I had an error with Unssuported... - maybe you didn't bump it here).