Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with TempDir failing when using a custom class... #1519

Merged

Conversation

leonard84
Copy link
Member

that extends from File or Path

fixes #1518

@leonard84 leonard84 self-assigned this Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1519 (0a7de01) into master (7f5e1ec) will increase coverage by 79.80%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             master    #1519       +/-   ##
=============================================
+ Coverage          0   79.80%   +79.80%     
- Complexity        0     4052     +4052     
=============================================
  Files             0      412      +412     
  Lines             0    12795    +12795     
  Branches          0     1655     +1655     
=============================================
+ Hits              0    10211    +10211     
- Misses            0     1985     +1985     
- Partials          0      599      +599     
Impacted Files Coverage Δ
...rk/runtime/extension/builtin/TempDirExtension.java 86.95% <50.00%> (ø)
...rc/main/java/org/spockframework/lang/Wildcard.java 80.00% <0.00%> (ø)
...ava/org/spockframework/compiler/SpecAnnotator.java 99.06% <0.00%> (ø)
...work/runtime/extension/builtin/RetryExtension.java 93.33% <0.00%> (ø)
.../runtime/extension/builtin/TempDirInterceptor.java 95.65% <0.00%> (ø)
.../main/java/org/spockframework/mock/MockNature.java 100.00% <0.00%> (ø)
...org/spockframework/compiler/model/ExpectBlock.java 100.00% <0.00%> (ø)
...spockframework/mock/CannotCreateMockException.java 66.66% <0.00%> (ø)
...kframework/runtime/extension/MethodInvocation.java 80.76% <0.00%> (ø)
... and 403 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@leonard84 leonard84 merged commit 22759cc into spockframework:master Sep 6, 2022
@leonard84 leonard84 deleted the fix-1518-tempdir-customclass branch September 6, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TempDir with custom class fails if class extends from File or Path
2 participants