Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the iteration is given to specification context #1686

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Jun 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (878ee9c) 79.78% compared to head (3ab4fd1) 79.80%.

Additional details and impacted files
@@                              Coverage Diff                              @@
##             verify-feature-in-specification-context    #1686      +/-   ##
=============================================================================
+ Coverage                                      79.78%   79.80%   +0.01%     
- Complexity                                      4079     4080       +1     
=============================================================================
  Files                                            425      425              
  Lines                                          12905    12906       +1     
  Branches                                        1629     1629              
=============================================================================
+ Hits                                           10296    10299       +3     
+ Misses                                          2002     2001       -1     
+ Partials                                         607      606       -1     
Files Changed Coverage Δ
...org/spockframework/runtime/PlatformSpecRunner.java 92.88% <100.00%> (+0.02%) ⬆️
...g/spockframework/runtime/SpecificationContext.java 100.00% <100.00%> (+8.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vampire Vampire requested a review from leonard84 June 2, 2023 14:19
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from 65b5c92 to a062966 Compare June 6, 2023 13:01
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from 5d2618e to ba9e318 Compare June 6, 2023 13:01
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from a062966 to 7abb52c Compare June 6, 2023 22:55
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from ba9e318 to 20365b5 Compare June 6, 2023 22:55
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from 7abb52c to cb528a1 Compare June 9, 2023 01:08
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from 20365b5 to 2bd231e Compare June 9, 2023 01:08
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from cb528a1 to d25271b Compare June 28, 2023 01:04
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from 2bd231e to f04eb29 Compare June 28, 2023 01:04
try {
currentIteration
assert false: 'currentIteration should not be set'
} catch (IllegalStateException ise) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could validate the ise messages to see if it is the expected one

@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from d25271b to 37ca9f3 Compare August 15, 2023 19:09
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from f04eb29 to 05a7fd2 Compare August 15, 2023 19:09
@Vampire Vampire requested a review from leonard84 August 15, 2023 19:22
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from 37ca9f3 to 5bf109b Compare August 21, 2023 12:56
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from 05a7fd2 to a234e83 Compare August 21, 2023 12:56
@Vampire Vampire force-pushed the verify-feature-in-specification-context branch from 5bf109b to 878ee9c Compare August 21, 2023 16:17
@Vampire Vampire force-pushed the verify-iteration-in-specification-context branch from a234e83 to 3ab4fd1 Compare August 21, 2023 16:17
@Vampire Vampire deleted the branch verify-feature-in-specification-context August 21, 2023 19:13
@Vampire Vampire closed this Aug 21, 2023
@Vampire Vampire deleted the verify-iteration-in-specification-context branch August 21, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants