Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs how to register all possible interceptors #1824

Merged
merged 2 commits into from Nov 12, 2023

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Nov 7, 2023

No description provided.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19c2bde) 80.64% compared to head (1c49943) 80.64%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1824   +/-   ##
=========================================
  Coverage     80.64%   80.64%           
- Complexity     4258     4260    +2     
=========================================
  Files           434      434           
  Lines         13265    13265           
  Branches       1687     1688    +1     
=========================================
  Hits          10698    10698           
  Misses         1952     1952           
  Partials        615      615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leonard84 leonard84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think we should add a disclaimer that although this will thoroughly intercept all possible things, this isn't actually what we recommend doing.
Furthermore, shouldn't it be specInfo.bottomSpec.allFeatures*., at least for IAnnotationDrivenExtension? IGlobalExtension will always apply only to the bottom spec.

We should probably document the specification hierarchy to better explain why bottomSpec/specsBottomToTop might be necessary and when it isn't.

@Vampire Vampire force-pushed the vampire/fix-possible-interceptors-example branch from 3c3183a to 42445ff Compare November 8, 2023 14:50
@Vampire
Copy link
Member Author

Vampire commented Nov 8, 2023

I added a disclaimer and there also mention considerations for local extensions regarding features vs. allFeatures and bottomSpec vs. not bottomSpec.

@Vampire Vampire force-pushed the vampire/fix-possible-interceptors-example branch 2 times, most recently from 992ad9d to ccc6ebb Compare November 9, 2023 12:10
@leonard84 leonard84 force-pushed the vampire/fix-possible-interceptors-example branch from ccc6ebb to 1c49943 Compare November 12, 2023 12:51
@leonard84 leonard84 enabled auto-merge (squash) November 12, 2023 12:52
@leonard84 leonard84 merged commit 9feb9dd into master Nov 12, 2023
40 checks passed
@leonard84 leonard84 deleted the vampire/fix-possible-interceptors-example branch November 12, 2023 13:04
@leonard84 leonard84 added this to the 2.4-M2 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants