New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs how to register all possible interceptors #1824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
=========================================
Coverage 80.64% 80.64%
- Complexity 4258 4260 +2
=========================================
Files 434 434
Lines 13265 13265
Branches 1687 1688 +1
=========================================
Hits 10698 10698
Misses 1952 1952
Partials 615 615 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I think we should add a disclaimer that although this will thoroughly intercept all possible things, this isn't actually what we recommend doing.
Furthermore, shouldn't it be specInfo.bottomSpec.allFeatures*.
, at least for IAnnotationDrivenExtension
? IGlobalExtension
will always apply only to the bottom spec.
We should probably document the specification hierarchy to better explain why bottomSpec
/specsBottomToTop
might be necessary and when it isn't.
3c3183a
to
42445ff
Compare
I added a disclaimer and there also mention considerations for local extensions regarding |
992ad9d
to
ccc6ebb
Compare
ccc6ebb
to
1c49943
Compare
No description provided.