Detached mocks (Issue 305) #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build.gradle
Conflicts: build.gradle
Conflicts: spock-tapestry/tapestry.gradle
|
Is there some kind of workaround for this? |
PolingCondition: IAE timeout value is negative
Add @PendingFeature
`Math.max(7, 4)` should return `7`, not `4`. Fixing this example also makes it consistent with the previous `MathSpec` example it is improving upon.
Added `distributionSha256Sum` for verification of downloaded Gradle distributions In case of wrong checksum the following error will be displayed Expected checksum: '2ba0aaa11a3e96ec0af31d532d808e1f09cc6dcad0954e637902a1ab544b9e60' Actual checksum: '<invalid SHA 256 checksum, which can be used for calculation of the next versions also>' See: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:verification
Upgraded Gradle and Groovy versions
The AppVeyor build is so slow that it causes the spec to fail, since the initial setup of the polling conditions eventually block takes to long. By decreasing the initialDelay, this should no longer be an issue. Furthermore, the timeouts for another test are reduced from seconds to milliseconds, as there is no reason to waste 5 seconds waiting.
…itions-spec Fix PollingConditionsSpec
Add support for handling additional Exception types with the PendingFeature annotation to allow features that are failing with exceptions instead of AssertionErrors.
…eature Add support for handling additional Exceptions with PendingFeature ...
For parametarized tests it could be important for a parameter to depend on a previously calculated value. Until now this wasn't possible, because the whole where block was calculated, before the test method was called (via its generated parameters). Also, the data providers calculate the whole column, before moving on to the next one, making the references seem unobvious. The fix was to provide the data provider methods with the list of already calculated columns. And because a cell should only refer to cells in the same row, the variable references were changed to array indexes (see the getAt part). This commit should play well with partial parameter definitions. Partially fixes spockframework#509
By annotating parameters with @language('Groovy') we'll have IDE support (e.g. syntax check and highlighting) for inlined languages (mostly used in tests)
…notation Added @language to String source code params
Update to cglib 3.2.0
Update Groovy from 2.4.4. to 2.4.5
…ting_example_in_doc Fix data driven testing example in documentation
Data table cells can reference previous ones
This implements spockframework#427 Move MockingApi to new spock.mock package.
leonard84
force-pushed
the
detached-mocks
branch
from
bf9056d
to
e62f71c
Compare
|
I will open a new PR this rebase makes no sense to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Spock Issue 305 according to https://groups.google.com/forum/#!topic/spockframework/pZXrWKzRV5U