Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to upgrade manual #88

Closed
grevus opened this issue Jul 27, 2017 · 2 comments
Closed

Add info to upgrade manual #88

grevus opened this issue Jul 27, 2017 · 2 comments

Comments

@grevus
Copy link

grevus commented Jul 27, 2017

Q A
Documentation yes
Library version 9+

Please, add information that you changed library for Base32 encoding to this file:

otphp/UPGRADE_v8-v9.md

-        $encoded_secret =  Base32\Base32::encode($secret);
+        $encoded_secret =  ParagonIE\ConstantTime\Base32::encodeUpper($secret);
@Spomky
Copy link
Member

Spomky commented Jul 27, 2017

Good catch.

As the version 8.3 is concerned by this change, I modified the README file instead of the otphp/UPGRADE_v8-v9.md one.

Thanks

@Spomky Spomky closed this as completed Jul 27, 2017
@grevus
Copy link
Author

grevus commented Jul 27, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants