Permalink
Browse files

Removing support for multiple query value notations.

  • Loading branch information...
Bob Aman
Bob Aman committed Jul 21, 2012
1 parent cf04765 commit f51e290b5f68a98293327a7da84eb9e2d5f21c62
Showing with 189 additions and 283 deletions.
  1. +1 −0 CHANGELOG.md
  2. +96 −155 lib/addressable/uri.rb
  3. +92 −128 spec/addressable/uri_spec.rb
View
@@ -2,6 +2,7 @@
- updated Addressable::Template to use RFC 6570, level 4
- fixed compatibility problems with some versions of Ruby
- moved unicode tables into a data file for performance reasons
+- removing support for multiple query value notations
# Addressable 2.2.8
- fixed issues with dot segment removal code
Oops, something went wrong.

2 comments on commit f51e290

@bblimke

This comment has been minimized.

Show comment Hide comment
@bblimke

bblimke Aug 7, 2012

This change breaks backwards compatibility in 2.x.x major version.
Do you have any recommendation on to upgrade libs depending on previous default "subscript" notation,
to be compatible with addressable >= 2.3.0? Is there any easy way to convert result of query_values(Array)
to a hash returned by subscript notation? i.e for "a[]=1&a[]=2"?

This change breaks backwards compatibility in 2.x.x major version.
Do you have any recommendation on to upgrade libs depending on previous default "subscript" notation,
to be compatible with addressable >= 2.3.0? Is there any easy way to convert result of query_values(Array)
to a hash returned by subscript notation? i.e for "a[]=1&a[]=2"?

@sporkmonger

This comment has been minimized.

Show comment Hide comment
@sporkmonger

sporkmonger Aug 7, 2012

Owner

Discussed already in issue #77.

I strongly recommend that everyone move away from the old notation if at all possible. If it's not possible, well, there's no reason you couldn't extract the old code from the commit preceding this one and run it side-by-side with the current version of Addressable via a subclass. I expect that approach will work for quite some time, though obviously it will be brittle to a degree.

Owner

sporkmonger replied Aug 7, 2012

Discussed already in issue #77.

I strongly recommend that everyone move away from the old notation if at all possible. If it's not possible, well, there's no reason you couldn't extract the old code from the commit preceding this one and run it side-by-side with the current version of Addressable via a subclass. I expect that approach will work for quite some time, though obviously it will be brittle to a degree.

Please sign in to comment.