Skip to content

Commit

Permalink
Removing support for multiple query value notations.
Browse files Browse the repository at this point in the history
  • Loading branch information
Bob Aman committed Jul 21, 2012
1 parent cf04765 commit f51e290
Show file tree
Hide file tree
Showing 3 changed files with 189 additions and 283 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- updated Addressable::Template to use RFC 6570, level 4
- fixed compatibility problems with some versions of Ruby
- moved unicode tables into a data file for performance reasons
- removing support for multiple query value notations

# Addressable 2.2.8
- fixed issues with dot segment removal code
Expand Down

2 comments on commit f51e290

@bblimke
Copy link

@bblimke bblimke commented on f51e290 Aug 7, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks backwards compatibility in 2.x.x major version.
Do you have any recommendation on to upgrade libs depending on previous default "subscript" notation,
to be compatible with addressable >= 2.3.0? Is there any easy way to convert result of query_values(Array)
to a hash returned by subscript notation? i.e for "a[]=1&a[]=2"?

@sporkmonger
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed already in issue #77.

I strongly recommend that everyone move away from the old notation if at all possible. If it's not possible, well, there's no reason you couldn't extract the old code from the commit preceding this one and run it side-by-side with the current version of Addressable via a subclass. I expect that approach will work for quite some time, though obviously it will be brittle to a degree.

Please sign in to comment.