New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier readme #1006
Prettier readme #1006
Conversation
Is there any information on audio quality I should add? |
Just say that we pull audio quality from YouTube. So the max you get is 128kbps. Also mention that YTM should be available in your country to use spotDL |
Also adds few tags from shield.io |
Okay. Yea I already have tags and the YTM note |
README.md
Outdated
|
||
# Installation | ||
You need to download ffmpeg to use this tool. Download and installation instructions can be found at [ffmpeg.org](https://ffmpeg.org/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For simplicity for the end user, some of whom may not be as technologically savvy, the original readme's links should be used
Directing users to the ffmpeg.org website adds space for error
See highlighted CORRECT link for windows, but most users would probably go for the big green "Download" button at the top of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change ffmpeg
to FFmpeg
as per FFmpeg's style guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if that helps a whole lot. If the user is unable to navigate the FFmpeg site, then I doubt they would be able to navigate the Windows site. Plus, since those are unofficial builds, I imagine they are subject to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm understood. Check with @Mikhail-Zex for the final call ig :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But do change ffmpeg
to FFmpeg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Silverarmor Thanks for noticing, will do.
@MikhailZex what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think both are exceedingly important. Do what you think is correct.
Nice to see jumping around already @Silverarmor |
Translation / Proofreading / documentation / admin in PRs and issues is my specialty haha, actual coding not so much, but working on improving my coding :) |
Could ya write up docs for spotdl then @Silverarmor ? |
I'd be happy to, Exams finish tomorrow for me, then I'm off school. |
README.md
Outdated
|
||
# Installation | ||
You need to download ffmpeg to use this tool. Download and installation instructions can be found at [ffmpeg.org](https://ffmpeg.org/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But do change ffmpeg
to FFmpeg
I'll hit you up by evening. |
@Silverarmor I agree, I was updating mine to reflect the changes @MikhailZex did at b9d55ff |
Plese keep |
Okay, that is better. |
@aklajnert to re-review ASAP, then PR is ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor notes. All good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Good deal. Thanks for y'alls help. Since @MikhailZex has the write permissions, just waiting on your call. |
Will merge asap. |
Well, great job guys. I just realized this PR has over 68 comments - shows the thought, time and dedication put in. Thank you. |
No description provided.