Icons, Docs and other changes #889

loftwah · 2020-10-13T11:45:08Z

Hello, I'd like to start contributing if you'll have me. I created a logo and did up a small style guide. I'd like to clean up the docs (set it up with something like readthedocs/gh pages or something) and add Docker support too.

*Total -- 28.81kb -> 12.92kb (55.16%) /images/spotdl-icon.png -- 22.57kb -> 9.05kb (59.88%) /images/color3@2x.png -- 2.17kb -> 1.27kb (41.51%) /images/color1@2x.png -- 2.01kb -> 1.26kb (37.01%) /images/color2@2x.png -- 2.07kb -> 1.33kb (35.6%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

[ImgBot] Optimize images

ghost · 2020-10-14T03:59:39Z

All contributions are welcome
First of all, lovely. I am working on the docs, I'd love if your willing to take over on that job.
Please keep your PR titles descriptive.
I like the icon but do design a few more (who know what we'll get, I usually get my best designs after chucking the first few...)
Gh-pages is cool. But I'd rather you it served as a landing page for users. The docs will be mostly used only by coders. Markdown is easier to handle for us coders than a webpage. We can discuss this when we get to it.
I'll look through the changes and merge them as soon as possible but please give me a week.

ghost · 2020-10-14T04:01:01Z

I looked through your code works, I assume your really good at js and decent at python. There's a GUI framework i plan to work on, wanna help out there too?

P.S. Your collaboration beats are dope.

loftwah · 2020-10-14T16:10:51Z

All contributions are welcome
Awesome! I'm very easy going and willing to learn. I consider myself intermediate but that can be relative depending on the kind of people I'm around. Please don't hesitate to deny any requests, I'm not the type of person to ever get upset about that sort of thing.

First of all, lovely. I am working on the docs, I'd love if your willing to take over on that job.
Yep, I'd be very happy to take over that job and it would be a good fit. If you have a plan of how you would like things done let me know, I'm happy to just roll with it otherwise.

I'd like to see if I could help push a Git project out of the realm of just coders being involved, which is why I've added things like the logo, color scheme (I just borrowed Spotify's colors) and a style guide so it bleeds into graphics design, possibly towards video, and social media (I believe this will be just as important as building applications in the future). If you've got any ideas, feel free to send them my way or if you want to keep the project minimal I'm cool with that too.

P.S. Your collaboration beats are dope.
Cheers man much appreciated! You into Hip Hop or music production at all?

ghost · 2020-10-14T17:39:00Z

I'm into music (weirrrrddddd music if I'm allowed to say so). I do some fine tuning on auditions but that's about it.

We think alike, wow! I want this project to grow beyond coders - a.k.a, I wanna make a gui so everyone can user it. I'm writing on a new framework on which I could use some Javascript and DOM help (if your interested, I'll send you an invite to the dev team)

I do have a few ideas, I'll send them your way tmrw or day after.

The icon you designed is good (way better than mine) but, could you design a few more? Send me the rough pencil concepts, let's see if we can improve.

loftwah · 2020-10-14T19:31:50Z

I'm into music (weirrrrddddd music if I'm allowed to say so). I do some fine tuning on auditions but that's about it.

We think alike, wow! I want this project to grow beyond coders - a.k.a, I wanna make a gui so everyone can user it. I'm writing on a new framework on which I could use some Javascript and DOM help (if your interested, I'll send you an invite to the dev team)

I do have a few ideas, I'll send them your way tmrw or day after.

The icon you designed is good (way better than mine) but, could you design a few more? Send me the rough pencil concepts, let's see if we can improve.

Sounds great man!! I'm glad I opened the issue initially.

ghost · 2020-10-16T18:28:15Z

Any progress bon the icons?

Sorry for the delay. It'll be at least a few more days before I can fill you in on the docs.

loftwah · 2020-10-17T08:01:32Z

Any progress bon the icons?

Sorry for the delay. It'll be at least a few more days before I can fill you in on the docs.

Not yet, I'll jump on it this weekend. Did you have any specific ideas in mind?

ghost · 2020-10-17T12:04:58Z

Not really. I'm kinda looking at at least 10 pencil (or pen or what ever you use) sketched concept icons

loftwah · 2020-10-19T21:01:54Z

Another sketch (a lot simpler this time).

loftwah · 2020-10-20T00:31:49Z

Here is the initial icon.

ohmerci · 2020-10-22T02:19:17Z

Cool, you can replace me if you want

ghost · 2020-10-22T03:41:12Z

@Sanches917 ???

ghost · 2020-10-23T04:29:31Z

Not really. I'm kinda looking at at least 10 pencil (or pen or what ever you use) sketched concept icons

I was looking at 'bulk', not simplicity. Basically, more ideas in total -> better chances of a good one. I like the decond one, plan to make a small modification, i'll put it up, tell me if you like it.

ghost · 2020-10-25T15:24:51Z

Sorry to keep you waiting soo long

ghost · 2020-10-25T15:25:10Z

Sorry to keep you waiting soo long

What do you think?

It's a mashup of your 'simplified' logo and spotify's logo. Feel free to mess around/modify it as you wish.

ghost · 2020-10-28T11:02:20Z

@loftwah ???

loftwah · 2020-10-28T17:09:53Z

Sorry to keep you waiting soo long

Awesome, I can refine this. I see the direction you want to go.

ghost · 2020-10-28T18:05:23Z

Nah, Nah, not direction I want to go.... It's just another idea. A logo should represent purpose, the earlier ones do, but not completely. So the alternate design SUGESSION

ghost · 2020-10-30T07:11:31Z

@loftwah Join in on discord.

(Check the team your on)

loftwah · 2020-10-30T10:55:39Z

Nah, Nah, not direction I want to go.... It's just another idea. A logo should represent purpose, the earlier ones do, but not completely. So the alternate design SUGESSION

Wicked, I like it either way. Check out what I just read haha we're working with a tough one.

“The Strange, Uninspired History of Spotify’s Bland Logo” by James I. Bowie https://link.medium.com/xmMk6GJg0ab

ghost · 2020-10-30T14:55:37Z

Nah, Nah, not direction I want to go.... It's just another idea. A logo should represent purpose, the earlier ones do, but not completely. So the alternate design SUGESSION

Wicked, I like it either way. Check out what I just read haha we're working with a tough one.

“The Strange, Uninspired History of Spotify’s Bland Logo” by James I. Bowie https://link.medium.com/xmMk6GJg0ab

All I can say is, the whole "unique by attrition" is working, I used to think that spotify was unique till a few seconds ago...

ghost · 2020-11-05T04:36:49Z

Yo, any updates?

P.S. join in on discord.

Silverarmor

A few minor grammar/spelling errors I have found.

Silverarmor · 2020-12-06T01:26:27Z

Docs/Design Docs/CORE VALUES.md

@@ -13,10 +13,10 @@ expected to merely satisfy the rule-of-thumb counterparts but push far beyond th
 # Our Values

 - Accurate & Fast Downloads - a user should be able to find and download the song
-he/she/them want in under 3 attempts at max and under 1 attempt most of the times and is
-the shortest time possible
+  he/she/them want in under 3 attempts at max and under 1 attempt most of the times and is


Line restates itself a bit, and also shouldn't use gender pronouns. Opt for The user instead of he/she/them.
Also the line doesn't make much sense, perhaps:

Accurate & Fast Downloads - A user should be able to find and download a song in under 3 attempts, but preferably only 1 attempt. Download times should also be as short as possible.

Silverarmor · 2020-12-06T01:26:58Z

Docs/Design Docs/CORE VALUES.md


 - Provide accurate metadata - all downloads should have the correct metadata.

 - Simple scalable design (Ease of contribution) - a programmer should understand what
-does what and be free to start working on his/her/their contributions in under 30 minutes.
+  does what and be free to start working on his/her/their contributions in under 30 minutes.


remove his/her/their and just use their

Silverarmor · 2020-12-06T01:28:11Z

Docs/Design Docs/PURPOSES.md

-would make for a lot of duplicate code. Serves as a ***single-point-of-access*** to 
-a ***singleton spotifyClient***.
+would make for a lot of duplicate code. Serves as a **_single-point-of-access_** to
+a **_singleton spotifyClient_**.

 [SEE ALSO.] initialize


the . after SEE ALSO is redundant

Silverarmor · 2020-12-06T01:28:49Z

Docs/Design Docs/PURPOSES.md

@@ -132,4 +132,4 @@ process instead of having it tracked in the main python process (its much simple

 [REA.] Using print methods in parallel with carriage returns (\r) for clean updates
 will print in new lines as the print call is from different processes. THis creates


THis --> This

Silverarmor · 2020-12-06T01:29:33Z

Docs/Design Docs/STYLE GUIDELINES.md

+
+## Thank You!
+
+If you are having trouble with anything in this guide please raise an issue request.


please create an issue* ?

Silverarmor · 2020-12-06T01:30:01Z

Docs/Design Docs/STYLE GUIDELINES.md

+R25 G20 B20
+C0 M0 Y0 K100
+
+#### Color rules


These rules don't render very well. Perhaps a list/table/similar?

Silverarmor · 2020-12-06T01:32:01Z

Docs/Design Docs/STYLE GUIDELINES.md

+RGB: R30 G215 B96
+CMYK: C80 M0 Y80 K0
+
+![alt text](../../images/color2@2x.png "White")


Note this is invisible if viewing on desktop github. Possibly add a black outline or similar?

Silverarmor · 2020-12-06T01:34:24Z

Also note that I prefer the README.md from #1006

Silverarmor · 2020-12-18T20:28:30Z

Bump @loftwah?

ghost · 2020-12-19T05:47:55Z

Nope. He's busy. Dont think he can help as of now.

ghost · 2021-01-01T04:11:34Z

Icons have been picked up. Docs are delayed. Closing this.

loftwah and others added 5 commits October 13, 2020 19:29

added imgs, style guide and modified folder struc

27b3002

added images to styleguide.md

d481efb

syntax failure. fixed.

623ed13

Merge pull request #1 from loftwah/imgbot

9e6d3e9

[ImgBot] Optimize images

Dean Lofts and others added 2 commits October 15, 2020 03:30

Merge branch 'master' into master

41f568a

Add .whitesource configuration file

77d4200

ghost changed the title ~~My initial changes~~ Icons, Docs and other changes Oct 15, 2020

ghost mentioned this pull request Oct 26, 2020

Unmerged pytube PR causes KeyError: 'adaptiveFormats' #806

Closed

4 tasks

phcreery mentioned this pull request Oct 30, 2020

CLI overhaul (+more) #895

Closed

Merge pull request #2 from loftwah/whitesource/configure

7e22be8

Silverarmor requested changes Dec 6, 2020

View reviewed changes

ghost closed this Jan 1, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Icons, Docs and other changes #889

Icons, Docs and other changes #889

loftwah commented Oct 13, 2020

ghost commented Oct 14, 2020

ghost commented Oct 14, 2020

loftwah commented Oct 14, 2020

ghost commented Oct 14, 2020 •

edited by ghost

loftwah commented Oct 14, 2020

ghost commented Oct 16, 2020

loftwah commented Oct 17, 2020

ghost commented Oct 17, 2020

loftwah commented Oct 19, 2020

loftwah commented Oct 20, 2020

ohmerci commented Oct 22, 2020

ghost commented Oct 22, 2020

ghost commented Oct 23, 2020

ghost commented Oct 25, 2020

ghost commented Oct 25, 2020 •

edited by ghost

ghost commented Oct 28, 2020

loftwah commented Oct 28, 2020

ghost commented Oct 28, 2020

ghost commented Oct 30, 2020

loftwah commented Oct 30, 2020

ghost commented Oct 30, 2020

ghost commented Nov 5, 2020

Silverarmor left a comment

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor Dec 6, 2020

Silverarmor commented Dec 6, 2020

Silverarmor commented Dec 18, 2020

ghost commented Dec 19, 2020 •

edited by ghost

ghost commented Jan 1, 2021

		@@ -132,4 +132,4 @@ process instead of having it tracked in the main python process (its much simple

		[REA.] Using print methods in parallel with carriage returns (\r) for clean updates
		will print in new lines as the print call is from different processes. THis creates


		## Thank You!

		If you are having trouble with anything in this guide please raise an issue request.

Icons, Docs and other changes #889

Icons, Docs and other changes #889

Conversation

loftwah commented Oct 13, 2020

ghost commented Oct 14, 2020

ghost commented Oct 14, 2020

loftwah commented Oct 14, 2020

ghost commented Oct 14, 2020 • edited by ghost

loftwah commented Oct 14, 2020

ghost commented Oct 16, 2020

loftwah commented Oct 17, 2020

ghost commented Oct 17, 2020

loftwah commented Oct 19, 2020

loftwah commented Oct 20, 2020

ohmerci commented Oct 22, 2020

ghost commented Oct 22, 2020

ghost commented Oct 23, 2020

ghost commented Oct 25, 2020

ghost commented Oct 25, 2020 • edited by ghost

ghost commented Oct 28, 2020

loftwah commented Oct 28, 2020

ghost commented Oct 28, 2020

ghost commented Oct 30, 2020

loftwah commented Oct 30, 2020

ghost commented Oct 30, 2020

ghost commented Nov 5, 2020

Silverarmor left a comment

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor Dec 6, 2020

Choose a reason for hiding this comment

Silverarmor commented Dec 6, 2020

Silverarmor commented Dec 18, 2020

ghost commented Dec 19, 2020 • edited by ghost

ghost commented Jan 1, 2021

ghost commented Oct 14, 2020 •

edited by ghost

ghost commented Oct 25, 2020 •

edited by ghost

ghost commented Dec 19, 2020 •

edited by ghost