Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #1038 #1043

Merged
3 commits merged into from Jan 1, 2021
Merged

Fix Issue #1038 #1043

3 commits merged into from Jan 1, 2021

Conversation

s1as3r
Copy link
Contributor

@s1as3r s1as3r commented Dec 17, 2020

Fixes #1038

  • When searching for a song, spotdl gathers all the results that the youtube music api provides.
  • If one of the songs in the results is not available in a country, 'playNavigationEndpoint' key would not be present in it's result, hence this error.

@s1as3r
Fix Issue #1038
ea22a87 
Fixes [Issue #1038](#1038)

- When searching for a song, spotdl gathers all the results that the youtube music api provides. 
- If one of the songs in the results is not available in a country, 'playNavigationEndpoint' key would not be present in it's result, hence this error.
@s1as3r s1as3r requested review from Silverarmor, phcreery and a user December 17, 2020 08:12
@s1as3r
Update provider.py
566abad 
Made Changes as suggested by @tytydraco
@Silverarmor
Copy link
Member

Apologies am very busy today, Will review when I can later.

@ghost
Copy link

ghost commented Dec 18, 2020

Pick 2 reviewers per PR. Will review this one this week.

@Silverarmor Silverarmor removed their request for review December 22, 2020 09:24
@s1as3r
Update provider.py
afb232d 
- Used `.get()` method instead of a try-except block.
@ghost ghost merged commit 162d7ce into spotDL:master Jan 1, 2021
@pithuene pithuene mentioned this pull request Jan 5, 2021
Closed
@Silverarmor Silverarmor added the Bug Fix PRs that fix bugs label Jan 8, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aklajnert aklajnert aklajnert approved these changes

@phcreery phcreery phcreery approved these changes

Assignees
No one assigned
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download error: KeyError: 'playNavigationEndpoint'
4 participants
@s1as3r @Silverarmor @aklajnert @phcreery