New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlist Download error - TypeError: remove #1044
Comments
I am getting the same results on both stable and latest version. This is happening on both previous 3.1.4 and current dev 3.2.0rc0
|
Also getting an issue on an install w/ fresh install.
|
Will look into it |
Dec version is still glitchy. Please keep to master |
Same here. Tried downloading a playlist, and it threw the same error. Is there a way to revert back to the old usable version again? |
As far as I know, the only thing you can do is a clean reinstall. Uninstall SpotDL and it's dependencies. Clear your pip cache, install SpotDL with pip. |
I have complete several fresh installations on different platforms (Windows & Linux) and it's still giving the same error msg. |
Same here... there's no solution yet, right? |
Bump. |
I think that I've found where the issue is. The __query_and_simplify() function in provider.py is not returning anything, no matter the input (from my tests) When it didn't return anything for the whole set of queries (whether that was an album, playlist, or a single track), the code tried to delete the .spotdltrackingfile that didn't exist (hence the nonetype error) Now, I'm not sure what all is supposed to be returned in the list from that function, but I found a possible api replacement at https://python-youtube-music.readthedocs.io/en/latest/ (on github at https://github.com/tombulled/python-youtube-music), it actually works to return a list of possible suggestions, although I find that it is lacking in the metadata department, so choosing a best fit may be harder if the algorithm relies on that. I'll try to integrate it tonight and see what happens |
Update: the ytm library works like a charm for getting a list of links, but it gives little to no metadata (not good) so I'm looking at the ytmusicapi library (https://ytmusicapi.readthedocs.io/en/latest/) because while I cannot get the search function to work, I can pass it a youtube video or song ID and get the metadata back (and formatted quite nicely for what we want it for, imo) |
@chhawkins2001, we get a ton of metadata from Spotify - much more than YouTube can provide (a full 1 mb of it) the only reason we need YouTube music is to get a song match on YouTube. |
Yea, I get that, but without the metadata from the second library, there would be no way to get an accurate match. There was no duration, artist, or correct album title, so we would be finding matches based on the title alone. I think I have a working implementation, so once my computer stops hating me, I'll make a pull request and y'all can see my not-up-to-standards code haha |
@chhawkins2001 I have tested your commit and looks like you missed off a file.
|
ah, I see the issue I forgot that ytm needs a seperate install because you can't just pip it directly from github, afaik heres the link to it: https://github.com/tombulled/python-youtube-music sorry about that! |
I'm not sure how to implement that directly in the code, because I haven't had much experience with package dependencies on github, so if someone with more experience could help me out with that, I would be so thankful |
Oh, and one last thing, I'm pretty sure you DO need the YouTubeMusicDL support |
Updates the expected return value of the YTM query.
Fixed it without the need for a new dependency |
Oh, nice! One issue though... While it works for the couple of the single tracks I tested, this album (https://open.spotify.com/album/3GmCXW10kLxmZrEY0JpRlw and I'm sure many others) does not work on your fix, while it does on mine, I'm not sure why, but no error is thrown, so I think that the underlying issue is still there, even though you fixed the obvious errors it was throwing Edit: I redact my statement, it was a config that i had broken on accident and not reverted, great fix! |
Updates the expected return value of the YTM query.
I'm a dummie when it comes to python and github. How can I get this fixed version? |
same thing happening to me. already did a clean install
|
@pithuene 's branch fixes this error for me. |
Figured out how to install branches. While @pithuene 's branch gave me Current spotDL master commit still gives me the first TypeError: Remove that this issue is based up on. |
The |
Can't download playlist on current master e8e5c5c
The text was updated successfully, but these errors were encountered: