Fix #995 #1065
Merged
Fix #995 #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the audio stream bitrate to ffmpeg.
aklajnert
reviewed
Jan 2, 2021
pithuene
force-pushed
the
audioBitrate
branch
2 times, most recently
from
902631c
to
172209e
Compare
The get_audio_only function defaults to filtering for mp4 streams. This seems arbitrary as ffmpeg has the capabilities for other codecs too and higher quality may be achieved this way.
Shell substitution was causing problems for file names containing dollar signs.
aklajnert
approved these changes
Jan 3, 2021
Merged
This was referenced Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the appropriate bitrate to ffmpeg so that files aren't all 64kpbs anymore. I am not actually sure whether this changes quality in any way because the resulting file size hardly changed at all. At the very least it sets the appropriate metadata.
Also the audio stream selection now chooses the stream with highest bitrate. Before it was limited to only mp4 streams.