Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All songs downloaded as 64kbps #995

Closed
outerepic opened this issue Nov 24, 2020 · 10 comments · Fixed by #1065
Closed

All songs downloaded as 64kbps #995

outerepic opened this issue Nov 24, 2020 · 10 comments · Fixed by #1065

Comments

@outerepic
Copy link

Hi,

I went to use spotDL today and began by updating the following:
pip3 install -U spotdl
pip3 install youtube-dl -U

I then downloaded a few albums and noticed the quality was always 64kbps. Could this just be because the youtube videos for the 5 albums I downloaded are low quality? Or is there a line of code I need to change to download files as they are on youtube?

Downloads were done on a Macbook with bitrate checked in native Music app. Let me know if you need any more information, two of the albums were Foxygen Hang and Neil Young Tonight's the Night if you want to test for yourself.

@ghost
Copy link

ghost commented Nov 24, 2020

That's just what we could get

+you don't need YouTub-dl
V3 is a complete rework with minimal deps

@marvic2409
Copy link

@outerepic if you want, you can put the links to the songs that were downloaded in the lower quality and I can take a look at it. Anyways it is likely that there were just uploaded to youtube with the lower quality.

@outerepic
Copy link
Author

@outerepic if you want, you can put the links to the songs that were downloaded in the lower quality and I can take a look at it. Anyways it is likely that there were just uploaded to youtube with the lower quality.

@marvic2409

I just tried downloading this playlist of Grammy Nominations for this year and they all came up as 64kbps. These songs are all pretty popular I imagine so I find it unlikely they would all be on youtube at 64kbps. Unless youtube changed something to limit upload quality to this. If you have any insight please let me know

https://open.spotify.com/playlist/6u3lNpboYHGfw1z2ZR0tix?si=OaNn6ydrS9edb0CAIxQ4yw

@ghost
Copy link

ghost commented Nov 29, 2020

@outerepic if you want, you can put the links to the songs that were downloaded in the lower quality and I can take a look at it. Anyways it is likely that there were just uploaded to youtube with the lower quality.

@marvic2409 thanks for the help

@jdahdah
Copy link

jdahdah commented Nov 29, 2020

Same issue here, all files are being downloaded at 64kbps when using the playlist download feature.

Example file:
Spotify song: https://open.spotify.com/track/0ZXvFSPhZy2Td1GYQBxqvt
Resolves to https://www.youtube.com/watch?v=0MheAxNjz6g

According to jDownloader, these variants are available:
CleanShot 2020-11-29 at 13 01 00@2x

@ghost
Copy link

ghost commented Nov 30, 2020

Update pytube from the upstream master manually. I think that should fix your problem.

@jdahdah
Copy link

jdahdah commented Nov 30, 2020

Update pytube from the upstream master manually. I think that should fix your problem.

Thanks. I assume you mean to run a pip install pytube manually?

I did this:

 ~ pip install pytube
Collecting pytube
  Downloading pytube-10.0.0-py3-none-any.whl (40 kB)
     |████████████████████████████████| 40 kB 309 kB/s
Requirement already satisfied: typing-extensions in /usr/local/lib/python3.9/site-packages (from pytube) (3.7.4.3)
Installing collected packages: pytube
Successfully installed pytube-10.0.0

But the issue remains, still getting 64 kbps.

@ghost
Copy link

ghost commented Dec 3, 2020

Thanks for the update. We'll look into it. As of now the devs are a bit busy so it'll take some time.

@outerepic
Copy link
Author

I tried doing 'pip3 install pytube' as suggested and am still getting all songs in 64kbps. I have been unable to find where the youtube download links are stored in v3 but it seems that these songs are available through other downloaders at 192kbps. I just did a brand new install of v3 for this test and sadly got the same results.

pithuene added a commit to pithuene/spotify-downloader that referenced this issue Dec 30, 2020
Pass the audio stream bitrate to ffmpeg.
@pithuene
Copy link
Contributor

The main issue was that ffmpeg converted the temp files to 64kpbs mp3 files. Looking at the temp files themselves bitrate was as expected. I created a fix in #1065.

pithuene added a commit to pithuene/spotify-downloader that referenced this issue Dec 30, 2020
Pass the audio stream bitrate to ffmpeg.
@Silverarmor Silverarmor linked a pull request Jan 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants