Add compilation times to BuildStep and issues fixed #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
approved these changes
Feb 13, 2020
| private func addCompilationTimesToTarget(_ target: BuildStep) -> BuildStep { | ||
| let lastCompilationStep = target.subSteps | ||
| .filter { $0.isCompilationStep() } | ||
| .max { $0.compilationEndTimestamp < $1.compilationEndTimestamp } |
BalestraPatrick
approved these changes
Feb 14, 2020
|
@ecamacho thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new Xcode's Build System, we've observed that the linking phase could happen a significant amount of time after the compilation phase. Because of this, by looking into the
durationfield of a target may be misleading, if you check the steps inside the target you could find that the compilation took a few seconds and the linking happened hundred of seconds later.This PR introduces two new fields:
compilationDurationandcompilationEndTimestampthat takes into account only the actual compilation time of a Target and an App.Also in this PR I fixed the issues #51 and #53