Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Add DiscoveryApi #2074

Merged
merged 6 commits into from
Aug 27, 2020
Merged

[RFC] Add DiscoveryApi #2074

merged 6 commits into from
Aug 27, 2020

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Aug 21, 2020

RFC PR to add DiscoveryApi 😁

It's a client-side version of #1847

Reasoning is explained in the definition docs

freben
freben reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@Rugvip Rugvip marked this pull request as ready for review August 22, 2020 09:55
@Rugvip Rugvip requested a review from a team as a code owner August 22, 2020 09:55
@soapraj soapraj merged commit 304b7bc into master Aug 27, 2020
@soapraj soapraj deleted the rugvip/discovery branch August 27, 2020 13:07
@Rugvip Rugvip mentioned this pull request Sep 4, 2020
Closed
@ParthS007 ParthS007 mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rugvip @freben @soapraj