feat: Return previous value on Provider STALE #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickybondarenko
requested review from
fabriziodemaria,
mfranberg,
vahidlazio and
nicklasl
as code owners
vahidlazio
reviewed
Apr 22, 2024
vahidlazio
reviewed
Apr 23, 2024
|
There are also some mentions of STALE in the docs to be updated, potentially in Confidence Documentation Portal as well |
|
I couldn't find anything in the provider internal docs.. But yes good point, we should create a ticket or mark in the docs ticket |
vahidlazio
approved these changes
Apr 23, 2024
vahidlazio
approved these changes
Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion within the team, it has been decided that when context is updated and provider is stale (hasn't resolved with new evaluation context / is about to resolve), in the meantime we would return previous value.