Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Python3 documentation #261

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Expand Python3 documentation #261

merged 1 commit into from
Feb 25, 2019

Conversation

rgson
Copy link
Contributor

@rgson rgson commented Nov 1, 2018

I had to add the --python flag when packaging a Python3 application. Otherwise, the virtualenv was built with Python2, regardless of build dependencies and triggers.

The option needed to create a Python3 environments when using the squence method (--with python-virtualenv) is well-documented through the example projects. It's not explicitly included in the documentation itself, though.

The experimental buildsystem alternative has not been used in any of the showcased projects. While obvious in hindsight, I found myself digging around for a bit to find the proper way of creating a Python3 environment with it.

I suggest that both methods are added to the Python3 cookbook section.

doc/howtos.rst Outdated Show resolved Hide resolved
@jhermann
Copy link
Contributor

jhermann commented Feb 8, 2019

Use

:option:`--python`

please (also they're called options, not flags). Same with env vars:

:envvar:`DH_VIRTUALENV_…`

@rgson
Copy link
Contributor Author

rgson commented Feb 8, 2019

Use

:option:`--python`

please (also they're called options, not flags). Same with env vars:

:envvar:`DH_VIRTUALENV_…`

Fixed.

@nailor
Copy link
Collaborator

nailor commented Feb 25, 2019

Thanks for the improvement on the docs! Consider it merged 😊

@nailor nailor merged commit 01d7bf0 into spotify:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants