Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a way to specify jobs which could affect other jobs #99

Closed
jcoveney opened this issue Jun 28, 2013 · 4 comments
Closed

Comments

@jcoveney
Copy link

Imagine you have a job where if it has run on date A, then it doesn't need to be run for any previous date. If you schedule a bunch of these, however, they will all be scheduled and run. You can manually short circuit the run with a check, but it would be nice to have a cleaner way to deal with these sort of situations.

@erikbern
Copy link
Contributor

Is it a recursive dependency? In requires(), you can just step backwards and find the last invocation of the same task and depend on it

@freider
Copy link
Contributor

freider commented Jul 1, 2013

@jcoveney Isn't the basic issue that you have different task instances with the same output target? Another way of solving it is to remove the parameters on the conflicting task...
I agree it would be useful and logical to make luigi track targets instead of task ids and it's something I have discussed offline with Erik a few times, but so far we've always found some non-trivial issue that prevents us from implementing it... Still think there should be a way to do it while maintaining the task/target model, but it will probably complicate the graph visualisation. For now, I think you can circumvent the problem by either doing the short circuit (self.complete()) check at the start of run() or just removing the parameter (making any run of the task allowable for the duration of your pipeline)

@Tarrasch
Copy link
Contributor

Tarrasch commented Jul 5, 2017

I'm closing this issue.

  • It has been inactive for +4 months.
  • It's not about luigi core, so not as many users are affected about this.
  • The change seems quite big, it's unlikely to be sporadically picked up.
  • The owner haven't responded or disappeared.
  • I don't understand what this is issue is about.
  • There exists a reasonable workaround for this.
  • We need to check if this hasn't been fixed by now (for old issues).

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.

Feel free to reopen this issue at any point if you have the intent to continue to work this. :)

@Tarrasch Tarrasch closed this as completed Jul 5, 2017
@Tarrasch
Copy link
Contributor

Tarrasch commented Jul 5, 2017

big change because: Luigi relies on configuration in code. Hard to analyze

workaround: There's the deps tools now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants