Fix for spotify/ramlfications#85 #88
Conversation
Current coverage is
|
|
woah 13 commits! I like a clean commit history (or as clean as possible) 😄 Please rebase/squash into one commit. |
| resources = create_resources(child.raw, resources, root, child) | ||
|
|
||
| return resources | ||
|
|
||
|
|
||
| def _create_supertype_resources(root, type_name, parent, supertype, resources): |
There was a problem hiding this comment.
I've used parent (and child) wording for nested resources; I think I'd rather call this parent types (and same with the parameter name)
|
Sorry, will do the squash/rebase. I'm a bit new to this stuff, so it might take me a while to figure out :) |
| if "type" in v: | ||
| # There may be some more methods defined on the resource | ||
| # type this one inherits from | ||
| supertype = v["type"] |
There was a problem hiding this comment.
I prefer the _get(v, "type") approach here since it's used elsewhere. e.g.:
if _get(v, "type"):
resources = _create_supertype_resources(root, k, parent, _get(v, "type"), resources)
|
@bpowell65536 here's a good resource that I point people to on rebasing/squashing commits. |
| # There may be some more methods defined on the resource | ||
| # type this one inherits from | ||
| supertype = v["type"] | ||
| resources = _create_supertype_resources( |
There was a problem hiding this comment.
Hmm, do we actually do anything with resources here after it's set?
There was a problem hiding this comment.
scratch that - I see it feeding into line 383
|
@bpowell65536 once you squash everything (FYI it will require a force-push since you essentially re-write history when squashing) and address the little nitpicks, I'll merge this. This looks good, thank you for catching this bug and giving a patch! |
|
@econchick Thanks! I have squashed everything now and pushed to my remote repository, but I'm not sure how to make the squashed commit appear instead of all the individual ones. Do I need to make a PR for the squashed commit instead? |
|
@bpowell65536 if you appropriately squashed everything, and (force) pushed to the same remote branch as before, then the pull request should automatically update. So I have a feeling it wasn't done correctly. |
No description provided.