Allow users to configure fetch and batch size for jdbc reads and writes #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## nio #1314 +/- ##
==========================================
- Coverage 81.73% 81.67% -0.07%
==========================================
Files 146 146
Lines 4244 4250 +6
Branches 373 313 -60
==========================================
+ Hits 3469 3471 +2
- Misses 775 779 +4
Continue to review full report at Codecov.
|
nevillelyh
suggested changes
Aug 21, 2018
syodage
force-pushed
the
shameera/jdbc-io-configs
branch
from
a14a6e7
to
da8aa14
Compare
|
@nevillelyh Done! |
nevillelyh
reviewed
Aug 21, 2018
| @@ -65,7 +65,8 @@ package object jdbc { | |||
| case class JdbcReadOptions[T](connectionOptions: JdbcConnectionOptions, | |||
| query: String, | |||
| statementPreparator: PreparedStatement => Unit = null, | |||
| rowMapper: ResultSet => T) extends JdbcIoOptions | |||
| rowMapper: ResultSet => T, | |||
| fetchSize: Option[Int] = None) extends JdbcIoOptions | |||
There was a problem hiding this comment.
Instead of requiring the user to wrap Int in Some here, what about use Int directly with a default of -1, which skips setting the fetch size?
nevillelyh
approved these changes
Aug 21, 2018
syodage
force-pushed
the
shameera/jdbc-io-configs
branch
from
dd331f4
to
b444ff9
Compare
nevillelyh
approved these changes
Aug 21, 2018
| package object jdbc { | ||
|
|
||
| type JdbcIO[T] = jdbc.nio.JdbcIO[T] | ||
| val JdbcIO = jdbc.nio.JdbcIO | ||
|
|
||
| private[jdbc] val USE_BEAM_DEFAULT_BATCH_SIZE = -1L |
There was a problem hiding this comment.
I wouldn't go crazy as de-magic-fy these since -1 is a pretty common pattern but that's just me ;)
There was a problem hiding this comment.
thought it is more informative what actually -1 means here.
nevillelyh
pushed a commit
that referenced
this pull request
Aug 24, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Aug 28, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Aug 30, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Aug 30, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Aug 31, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 5, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 5, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 5, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 6, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 7, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 11, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 12, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 13, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 13, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 14, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 14, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
nevillelyh
pushed a commit
that referenced
this pull request
Sep 17, 2018
…es (#1314) * Allow users to configure fetch and batch size for jdbc read and write * clean the api a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311