Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdk11 build steps #1361

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Add jdk11 build steps #1361

merged 1 commit into from
Sep 12, 2018

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Sep 12, 2018

Fixes #1360

@regadas regadas force-pushed the issue/1360 branch 9 times, most recently from b08c3da to 6cfbe6f Compare September 12, 2018 21:27
@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #1361 into master will decrease coverage by 8.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   79.82%   71.36%   -8.46%     
==========================================
  Files         125      125              
  Lines        4213     4027     -186     
  Branches      475      367     -108     
==========================================
- Hits         3363     2874     -489     
- Misses        850     1153     +303
Impacted Files Coverage Δ
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-100%) ⬇️
...scala/com/spotify/scio/bigquery/MockBigQuery.scala 0% <0%> (-95.13%) ⬇️
...la/com/spotify/scio/bigquery/dynamic/package.scala 0% <0%> (-94.45%) ⬇️
...potify/scio/runners/dataflow/DataflowContext.scala 0% <0%> (-92.86%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 6.25% <0%> (-87.5%) ⬇️
...cio/bigquery/dynamic/DynamicDestinationsUtil.scala 0% <0%> (-80%) ⬇️
...n/scala/com/spotify/scio/bigtable/TableAdmin.scala 0% <0%> (-80%) ⬇️
...ala/com/spotify/scio/bigquery/BigQueryClient.scala 9.22% <0%> (-71.43%) ⬇️
...ala/com/spotify/scio/avro/types/TypeProvider.scala 45.71% <0%> (-41.43%) ⬇️
...n/scala/com/spotify/scio/avro/types/AvroType.scala 55.55% <0%> (-33.34%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce0ec...7881c1a. Read the comment docs.

@regadas regadas merged commit 4333b82 into spotify:master Sep 12, 2018
@regadas regadas deleted the issue/1360 branch September 12, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants