Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple sorter method #2542

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Add simple sorter method #2542

merged 3 commits into from
Jan 22, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Dec 17, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #2542 into master will decrease coverage by 1.35%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2542      +/-   ##
=========================================
- Coverage   68.26%   66.9%   -1.36%     
=========================================
  Files         207     208       +1     
  Lines        7253    7273      +20     
  Branches      342     325      -17     
=========================================
- Hits         4951    4866      -85     
- Misses       2302    2407     +105
Impacted Files Coverage Δ
...la/com/spotify/scio/coders/CoderMaterializer.scala 100% <100%> (ø) ⬆️
...y/scio/extra/sorter/syntax/SCollectionSyntax.scala 95% <95%> (ø)
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-52.5%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-41.18%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 60% <0%> (-35%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 16.66% <0%> (-33.34%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0% <0%> (-31.71%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 50.72% <0%> (-23.19%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 37.98% <0%> (-3.85%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aff2cb...c6c6619. Read the comment docs.

@nevillelyh
Copy link
Contributor

Should we discuss issues with SortValues in #2530 first?

@regadas regadas marked this pull request as ready for review January 8, 2020 15:54
@regadas
Copy link
Contributor Author

regadas commented Jan 15, 2020

@nevillelyh I think we can merge this one as well

@nevillelyh
Copy link
Contributor

I'll look in a bit.

@regadas regadas added this to the 0.8.1 milestone Jan 16, 2020
@regadas regadas added the enhancement New feature or request label Jan 16, 2020
@nevillelyh nevillelyh merged commit 86f1fb7 into spotify:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants