Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2582: Fix ClassCastEx in PubSubIO #2583

Merged
merged 2 commits into from
Jan 9, 2020
Merged

#2582: Fix ClassCastEx in PubSubIO #2583

merged 2 commits into from
Jan 9, 2020

Conversation

jto
Copy link
Contributor

@jto jto commented Jan 9, 2020

fixes #2582

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #2583 into master will increase coverage by 0.17%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
+ Coverage   68.23%   68.41%   +0.17%     
==========================================
  Files         207      207              
  Lines        7254     7254              
  Branches      349      354       +5     
==========================================
+ Hits         4950     4963      +13     
+ Misses       2304     2291      -13
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/VersionUtil.scala 75.67% <0%> (ø) ⬆️
.../src/main/scala/com/spotify/scio/io/PubsubIO.scala 31.25% <100%> (+10%) ⬆️
...main/scala/com/spotify/scio/util/BloomFilter.scala 94.2% <0%> (+0.72%) ⬆️
...scala/com/spotify/scio/extra/sparkey/package.scala 75.82% <0%> (+1.09%) ⬆️
...y/scio/values/PairSkewedSCollectionFunctions.scala 93.75% <0%> (+3.12%) ⬆️
...spotify/scio/coders/instances/BeamTypeCoders.scala 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6673553...654620c. Read the comment docs.

@regadas
Copy link
Contributor

regadas commented Jan 9, 2020

@jto can you rebase I fix the formatting in master.

@regadas
Copy link
Contributor

regadas commented Jan 9, 2020

scratch that i see that you fixed it here as well 😄

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jto outside of this PR; but it seems that the only classes that need ClassTag are AvroPubsubIOWithoutAttributes & MessagePubsubIOWithoutAttributes or am I missing smth?

@nevillelyh nevillelyh merged commit 0966a51 into master Jan 9, 2020
@nevillelyh nevillelyh deleted the julient/fix-2582 branch January 9, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassCastException from PubsubIO.apply()
3 participants