Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests on Coders #2639

Merged
merged 4 commits into from
Jan 28, 2020
Merged

More tests on Coders #2639

merged 4 commits into from
Jan 28, 2020

Conversation

jto
Copy link
Contributor

@jto jto commented Jan 28, 2020

Coverage up ~3.5%

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2639 into master will increase coverage by 3.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2639      +/-   ##
==========================================
+ Coverage    68.2%   71.72%   +3.51%     
==========================================
  Files         208      208              
  Lines        7310     7310              
  Branches      370      350      -20     
==========================================
+ Hits         4986     5243     +257     
+ Misses       2324     2067     -257
Impacted Files Coverage Δ
...om/spotify/scio/coders/instances/ScalaCoders.scala 82.72% <100%> (+5%) ⬆️
...main/scala/com/spotify/scio/util/BloomFilter.scala 93.47% <0%> (-1.45%) ⬇️
...src/main/scala/com/spotify/scio/coders/Coder.scala 84.18% <0%> (+1.02%) ⬆️
...cala/com/spotify/scio/coders/KryoAtomicCoder.scala 69.84% <0%> (+6.34%) ⬆️
...om/spotify/scio/coders/instances/TupleCoders.scala 100% <0%> (+95.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e842763...3657b79. Read the comment docs.

@jto jto marked this pull request as ready for review January 28, 2020 15:26
@regadas regadas merged commit c25960f into master Jan 28, 2020
@regadas regadas deleted the julient/improve-test-coverage branch January 28, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants