Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for String/ByteString TF Bucket key types #3098

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

nmaraston
Copy link
Contributor

String/ByteString key types are supported when writing TF Examples to SMB buckets (since the type need only be encodeable). These types are however not supported when reading TF Examples from said buckets.

This PR adds support for String/ByteString key types when extracting SMB bucket keys.

@martinbomio
Copy link
Contributor

lgtm!

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #3098 into master will decrease coverage by 2.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   72.20%   69.65%   -2.56%     
==========================================
  Files         232      232              
  Lines        7697     7697              
  Branches      352      333      -19     
==========================================
- Hits         5558     5361     -197     
- Misses       2139     2336     +197     
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 52.11% <0.00%> (-22.54%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892ea04...607bb7c. Read the comment docs.

@nevillelyh nevillelyh merged commit 7cd2e6c into spotify:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants