Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused macro import #3353

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Sep 24, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3353 into master will decrease coverage by 2.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3353      +/-   ##
==========================================
- Coverage   72.70%   70.17%   -2.53%     
==========================================
  Files         234      234              
  Lines        7708     7708              
  Branches      333      337       +4     
==========================================
- Hits         5604     5409     -195     
- Misses       2104     2299     +195     
Impacted Files Coverage Δ
...e/src/main/scala/com/spotify/scio/schemas/To.scala 94.11% <ø> (ø)
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 21.87% <0.00%> (-40.63%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470c1ea...2acc263. Read the comment docs.

@regadas regadas merged commit aa47d96 into spotify:master Sep 24, 2020
@regadas regadas deleted the rm_unused_macro_import branch September 24, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant