Skip to content

Commit

Permalink
chore: use global .gitignore to ignore web-scripts generated files
Browse files Browse the repository at this point in the history
  • Loading branch information
Paul Marbach committed Jul 1, 2019
1 parent 026b085 commit 64ea2b4
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
7 changes: 6 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,9 @@ typings/
.fusebox/

# DynamoDB Local files
.dynamodb/
.dynamodb/

# web-scripts generated files
cjs/
esm/
types/
4 changes: 0 additions & 4 deletions packages/web-scripts/.gitignore

This file was deleted.

6 changes: 5 additions & 1 deletion packages/web-scripts/src/integration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const TEST_SCRIPTS_TIMEOUT = 60000;
// const GITHUB_URL = 'https://github.com/spotify/web-scripts.git';

describe('integration tests', () => {
const MONOREPO_ROOT = join(root, '../..');
let PKG_ROOT: string;

beforeEach(() => {
Expand Down Expand Up @@ -148,7 +149,10 @@ describe('integration tests', () => {
join(PKG_ROOT, 'src', fileName),
),
);
await copyFile(join(THIS_ROOT, '.gitignore'), join(PKG_ROOT, '.gitignore'));
await copyFile(
join(MONOREPO_ROOT, '.gitignore'),
join(PKG_ROOT, '.gitignore'),
);

// install the dependencies we specified above in pkg
// this is what is making the tests fail
Expand Down

0 comments on commit 64ea2b4

Please sign in to comment.