Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese Simplified translation by xiezhhw and rhcad. #100

Merged
merged 2 commits into from Apr 4, 2014

Conversation

rhcad
Copy link
Collaborator

@rhcad rhcad commented Mar 23, 2014

We have translated the help page and localizable strings into Chinese, and tested on iPad too.

The main apple store page translated into Chinese can be download.

Translators:
Pillow Tse https://github.com/xiezhhw
Zhang Yungui https://github.com/rhcad

@rhcad rhcad mentioned this pull request Mar 23, 2014
sprang added a commit that referenced this pull request Apr 4, 2014
Add Chinese Simplified translation by xiezhhw and rhcad.
@sprang sprang merged commit c54772d into sprang:develop Apr 4, 2014
@sprang
Copy link
Owner

sprang commented Apr 4, 2014

I really appreciate this translation -- Thanks!

A note for the future: A bunch of XIBs were changed with this patch, but they weren't actually modified (they just got a new version number when Xcode autosaved). I try not to include these in commits, since they don't have any intentional changes. XIBs can be fragile, so it's nice to know that any commit involving them involves a real change. This is just a nitpick though!

@rhcad
Copy link
Collaborator Author

rhcad commented Apr 4, 2014

I just imitated by the German translation to change XIBs. I should ask you firstly on this point, although it works. Thank you for pointing out the reason.

@sprang
Copy link
Owner

sprang commented Apr 4, 2014

Thought on this a bit more... It's annoying that Xcode keeps modifying the files, so it's probably worth it to commit them when the version changes. Ideally, it would be a distinct commit that just adds the XIBs with new version numbers (and no other changes). Anyway, no big deal. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants