Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins are rendered wrong #120

Closed
SpraxDev opened this issue Jun 6, 2020 · 1 comment · Fixed by #121
Closed

Skins are rendered wrong #120

SpraxDev opened this issue Jun 6, 2020 · 1 comment · Fixed by #121
Assignees
Labels
bug Something isn't working

Comments

@SpraxDev
Copy link
Owner

SpraxDev commented Jun 6, 2020

Describe the bug
The 2D Renderer has problems with skin overlays having an alpha of below 100% replacing the pixel underneath it instead of still showing the one below.

The 3D Renderer has a simillar problem, where rendering such overlay, not showing what's behind that pixel.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://api.sprax2013.de/mc/skin/x-url/body?url=https://cdn.skindb.net/skins/2258170679830512715 and https://api.sprax2013.de/mc/skin/x-url/body/3d?url=https://cdn.skindb.net/skins/2258170679830512715
  2. 2d 2D version has white (transparent) pixels around the goggles (less than 100% alpha, but fully replacing the pixel underneath it)
  3. 3d 3D version has a large transparent area around its neck that should not be there
@SpraxDev SpraxDev added the bug Something isn't working label Jun 6, 2020
@SpraxDev SpraxDev self-assigned this Jun 6, 2020
@SpraxDev
Copy link
Owner Author

SpraxDev commented Jun 6, 2020

The cache might need some time to catch up again - But the fix is now live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant