Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spree 4.1 update #841

Closed
Ghaithdabash opened this issue Aug 29, 2020 · 3 comments
Closed

Spree 4.1 update #841

Ghaithdabash opened this issue Aug 29, 2020 · 3 comments
Assignees

Comments

@Ghaithdabash
Copy link
Contributor

I have two issues after updating spree to the new version:

1- Uncaught ReferenceError: Spree is not defined On Spree.url_params["locale"] = "en";
2- Deface adds_locales_bar_to_main_nav_bar is not working

Any idea why this would happen?
Thanks

@jsandeo
Copy link

jsandeo commented Sep 9, 2020

I'm having the exact same issue.

So far I think it might have to do with /spree_i18n/app/overrides/spree/adds_params_to_body.rb rendering the javascript code at /spree_i18n/app/views/spree/layouts/_add_js_params.html.erb via Deface, which should probably be done through the asset loading chain. Still working on the fix, though.

Did you manage to work it out?

@damianlegawiec damianlegawiec self-assigned this Sep 10, 2020
@Ghaithdabash
Copy link
Contributor Author

I didnt manage to work it out, i tried few things but the issue is not solved

@damianlegawiec
Copy link
Contributor

Fixed via #844

Thank you all for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants