Ensure Railtie has eager_load_paths #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that gems may define a Railtie without defining `eager_load_paths` (such as `dotenv-rails`), which causes this function to fail. Extend the `next` clause to ensure the existence of `eager_load_paths` to prevent this failure.
|
This should resolve #139 |
|
+1 |
|
Has this been fixed? I am running into the same issue. |
|
What's this waiting on? |
|
@jarednorman I imagine the CI failures, which are unrelated and I also fixed in #141 |
|
Maybe we should submit a PR to dotenv implementing eager_load_paths as a NOP |
huoxito
added a commit
that referenced
this pull request
Apr 16, 2015
Ensure Railtie has eager_load_paths
|
thanks a lot for the patches @alexblackie !!! |
|
Hi, does the fix have beed released? |
|
I dont think so Edwin you will need to point to github to get it On Wed, Jun 3, 2015 at 12:27 PM, Edwin Lunando notifications@github.com
Washington L Braga Jr Developer |
|
What are we waiting for to get this released? |
|
I think we need @BDQ for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that gems may define a Railtie without defining
eager_load_paths(such asdotenv-rails), which causes this functionto fail. Extend the
nextclause to ensure the existence ofeager_load_pathsto prevent this failure.