Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can add first variant to product without option types #5639

Closed
JDutil opened this issue Nov 19, 2014 · 1 comment
Closed

Can add first variant to product without option types #5639

JDutil opened this issue Nov 19, 2014 · 1 comment

Comments

@JDutil
Copy link
Member

JDutil commented Nov 19, 2014

The link to "add one" variant is appearing on the variants page for products without option types assigned. This should not be possible, and correctly goes away once the first variant is added...
@nishant-cyro
Copy link
Contributor

@priyank-gupta @Mafi88 @damianlegawiec @JDutil - Able to replicate this one. Looking into it.

@Mafi88 Mafi88 closed this as completed in 1e54d2b Feb 17, 2016
Mafi88 added a commit that referenced this issue Feb 17, 2016
@Mafi88
Merge pull request #7045 from vinsol/fixes_5639
08d8d85 
Fixes #5639, add presence validation for option_values in variant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JDutil @nishant-cyro @spreebot