Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frontend/backend fully optional when installing spree gem #11105

Merged
merged 7 commits into from
Jun 15, 2021

Conversation

damianlegawiec
Copy link
Member

@damianlegawiec damianlegawiec commented Jun 13, 2021

This makes Spree a more modular and headless API-first platform.

  1. spree gem does not include spree_frontend nor spree_backend
  2. spree_frontend and spree_backend don't require specific spree_core / spree_api version, so older frontend can work with newer spree_core (scenario: developer updated spree core, spree API but does not update spree frontend at the same time)

@damianlegawiec damianlegawiec added this to the 4.3 milestone Jun 13, 2021
@viezly
Copy link

viezly bot commented Jun 13, 2021

Full changes overview:

Show details on Viezly ➡️

@damianlegawiec damianlegawiec force-pushed the feature/frontend-optional branch 2 times, most recently from ee502ce to 44797ed Compare June 13, 2021 21:19
@damianlegawiec damianlegawiec changed the title Make spree_frontend gem optional and drop exact spree version requirement Make frontend/backend fully optional when installing spree gem Jun 14, 2021
@damianlegawiec damianlegawiec marked this pull request as ready for review June 14, 2021 17:10
## Install missing migrations

```bash
rails spree:install:migrations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add the frontend install command to the docs
bundle exec rails g spree:frontend:install

@MatthewKennedy
Copy link
Contributor

MatthewKennedy commented Jun 15, 2021

Hi @damianlegawiec

I've just fired this up locally

  • Installed spree_core only - Worked Perfectly
  • Added spree_frontend gem (gem 'spree_frontend', path: '../spree/frontend') and run the install command - Worked Perfectly
  • Added backend gem (gem 'spree_backend', path: '../spree/backend') - Worked Perfectly

Notes: Had to use local path to the gems, as I think the frontend and backend stand alone gems are not published, or if published possibly need updating when the time is right.

Documentation of the install commands is about the only thing I had to find out by a little digging during the install process:
bundle exec rails g spree:frontend:install
bundle exec rails g spree:backend:install

Other than that, very nice!

@damianlegawiec
Copy link
Member Author

Hi @damianlegawiec

I've just fired this up locally

  • Installed spree_core only - Worked Perfectly
  • Added spree_frontend gem (gem 'spree_frontend', path: '../spree/frontend') and run the install command - Worked Perfectly
  • Added backend gem (gem 'spree_backend', path: '../spree/backend') - Worked Perfectly

Notes: Had to use local path to the gems, as I think the frontend and backend stand alone gems are not published, or if published possibly need updating when the time is right.

Documentation of the install commands is about the only thing I had to find out by a little digging during the install process:
bundle exec rails g spree:frontend:install
bundle exec rails g spree:backend:install

Other than that, very nice!

Awesome! Yes, we need to update the docs after the first public 4.3 release and yes frontend/backend gems need to be updated on rubygems, actually you can run the generators/installers from the main one by:

rails g spree:install --install_storefront=true --install_admin=true

@damianlegawiec damianlegawiec merged commit 6f6965a into master Jun 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/frontend-optional branch June 15, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants