Migrate User Roles code from Spree Auth Devise to Spree Core #11108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: |
damianlegawiec
force-pushed
the
feature/migrate-user-auth
branch
from
08d3fd2
to
d5c694f
Compare
Also.. 1. Optimized the `has_spree_role?` method (one SQL query rahter than grabbing the entire collection and itering through it) 2. Added `Spree::UserRoles` concern
damianlegawiec
force-pushed
the
feature/migrate-user-auth
branch
from
d5c694f
to
00e14be
Compare
damianlegawiec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.