Fix user's shipping & billing address interaction with order #11660
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty, and preferences can be {} so check for blank?
…r and also potentially a deleted address
|
Changes preview: Legend: |
|
This is tackling simliar problems to my PR here: #11606, maybe we want to merge this into one PR? |
|
@stefnnn yes we could. Although your PR was not merged after 2 months. I am afraid the maintainers are sleeping? |
stefnnn
added a commit
to stefnnn/spree
that referenced
this pull request
Mar 13, 2022
Copied from @mrbrdo, see spree#11660
|
@damianlegawiec ping, this is kinda important. Been using these fixes in production for a while now, no issues at all. |
…, fix this It would be more proper to put this into an Order after_save hook, but the same can be said for calling the update_or_create_address method, so I will leave that to a future refactor
The Order should use_billing == true if ship_address is missing, is empty, or is the same as bill_address
mrbrdo
force-pushed
the
fix_user_address_main
branch
from
262970a
to
0fa0dbe
Compare
|
Updated to correctly determine use_billing? (fixes issue if ship is same as bill and gets updated in checkout form) |
|
@damianlegawiec what do you think? |
|
@damianlegawiec well?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues regarding this, see the individual commits.
This also makes legacy frontend work correctly:
This was quite broken with even a security issue with the unscoped Spree::Address query. I suggest to merge asap due to this.