Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user's shipping & billing address interaction with order #11660

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix user's shipping & billing address interaction with order #11660

wants to merge 6 commits into from

Commits on Mar 12, 2022

  1. new order uses shipping and billing address of user - fix so it's act… 

    …ually used
    @mrbrdo
    mrbrdo committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    95a854a View commit details
    Browse the repository at this point in the history

  2. fix address empty? since even with a user_id it should be considered … 

    …empty, and preferences can be {} so check for blank?
    @mrbrdo
    mrbrdo committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    4e3886e View commit details
    Browse the repository at this point in the history

  3. fix issue where order can be assigned an address from a different use… 

    …r and also potentially a deleted address
    @mrbrdo
    mrbrdo committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    e6549b0 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. user's billing/shipping address will not update when order is updated… 

    …, fix this

It would be more proper to put this into an Order after_save hook, but the same can be said for
calling the update_or_create_address method, so I will leave that to a future refactor
    @mrbrdo
    mrbrdo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b835982 View commit details
    Browse the repository at this point in the history

  2. When creating Order, correctly assign ship_address or use_billing 

    The Order should use_billing == true if ship_address is missing, is empty, or is the same as bill_address
    @mrbrdo
    mrbrdo committed May 12, 2022
    Configuration menu
    Copy the full SHA
    0fa0dbe View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. don't assign ship_address to order if use_billing was checked in chec… 

    …kout
    @mrbrdo
    mrbrdo committed May 26, 2022
    Configuration menu
    Copy the full SHA
    be740fe View commit details
    Browse the repository at this point in the history