Calculator change in shipping methods broken again #1331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide some steps to reproduce the issue that you're encountering so we can be sure that this patch fixes something. |
|
Of course.
|
|
Thanks, will take a look into this. |
|
I can confirm this is a problem. Will write a test to reproduce it. |
| @@ -1,8 +1,9 @@ | |||
| $(function() { | |||
| var original_calc_type = $('#calc-type').attr('value'); | |||
| var calculator_select = $('select#shipping_method_calculator_type') | |||
There was a problem hiding this comment.
This calculator js is used on the tax rates form too, and so by changing it here you're breaking it on the tax rates form. imo it should be select#calc-type still so it remains compatible.
There was a problem hiding this comment.
Oh, i see. So problem in partial /admin/shared/_calculator_fields.html.erb
|
First commit contains your changes, second commit contains my changes to your changes and a spec to test it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small selector fix.