Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword changed to keywords in taxon show #2258

Closed
wants to merge 1 commit into from
Closed

keyword changed to keywords in taxon show #2258

wants to merge 1 commit into from

Conversation

reinaris
Copy link
Contributor

Changed keyword to keywords for taxons/show

@radar
Copy link
Contributor

radar commented Nov 29, 2012

Can you please write a regression test for this?

@reinaris
Copy link
Contributor Author

No sorry I can't.. never wrote one, I'm just a simple frontender :)

@radar
Copy link
Contributor

radar commented Nov 29, 2012

Then please explain how I can reproduce the issue that this pull request fixes. I will reproduce it locally and when I do that then I can write a test for it.

On 29/11/2012, at 20:29, Rein Aris notifications@github.com wrote:

No sorry I can't.. never wrote one, I'm just a simple frontender :)


Reply to this email directly or view it on GitHub.

@reinaris
Copy link
Contributor Author

Will do that.
I shall update this ticket soon!

@radar
Copy link
Contributor

radar commented Dec 2, 2012

I will be closing this issues at the end of this week if there is no steps to reproduce the problem.

@GeekOnCoffee
Copy link
Contributor

in a store with sample data:
http://localhost:3000/t/brands/?utf8=%E2%9C%93&keywords=baseball

If keywords are specified, it should show only one collection of search results. Without this fix, it shows the main search results and also the search results broken out by taxon.

GeekOnCoffee added a commit to GeekOnCoffee/spree that referenced this pull request Dec 3, 2012
@GeekOnCoffee GeekOnCoffee mentioned this pull request Dec 3, 2012
@GeekOnCoffee
Copy link
Contributor

Created a PR #2270 with this commit and a test.

@reinaris
Copy link
Contributor Author

reinaris commented Dec 3, 2012

Thanks @GeekOnCoffee !!

@radar radar closed this in 6f51c87 Dec 4, 2012
radar pushed a commit that referenced this pull request Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants