Fix duplicate result if name contains SKU

[jphpsf]

My Spree app happens to have product names that includes part of the SKUs. When I create an order in the admin, the products autocomplete then return duplicated results (because both the SKU and the name matches)

Step to reproduce: in the Spree admin, create a product named "ABC test" with a SKU "ABC123". Go to the Orders tab and create a New Order. Search for "ABC" in the product field. When the autocomplete results appears you should see a duplicate entry for "ABC test".

Expected behavior: no duplicate entries :)

Broken behavior: duplicate entries!

Fix: the fix is trivial. In the product controller, I added a call to #uniq at the end of the #collection method. Also added a test to verify the behavior.

Cheers!

[radar]

This PR breaks tests on PostgreSQL: https://travis-ci.org/spree/spree/jobs/4038324. Could you please take a look at that?

[jphpsf]

Sure thing. It looks like it's breaking the products HTML table. Should be easy to fix.

[radar]

Looks like an SQL error: https://travis-ci.org/spree/spree/jobs/4038324/#L99.
I think we tried addressing this previously and ran into some difficulties.

On Mon, Jan 14, 2013 at 11:57 AM, JP notifications@github.com wrote:

Sure thing. It looks like it's breaking the products HTML table. Should be
easy to fix.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2409#issuecomment-12203832.

[jphpsf]

I understand know why I did not see the test failure. By default rake spec uses sqlite which did not have the problem. Anyway, gonna need to spend some time on this one :)

[jphpsf]

The fix was pretty simple. Because the bug was really only affecting the JSON API, I moved the uniq call to the XHR block. Tests are passing locally with postgresql and sqlite.

[radar]

I think this one is fixed now :)