Use built in leaf? method for detecting no children. #6188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage to preview changes. Open stage or view logs. |
|
👍 This is a slight change in logic, but given my understanding of awesome_nested_set, I believe both to be correct, with this one being significantly more efficient. Thanks for your work on this. |
|
That's right, this is a change in logic but uses nested set logic instead of expensive database queries. |
|
Is this something you wanted back to 2-4-stable as well? |
JDutil
pushed a commit
to JDutil/spree
that referenced
this pull request
Mar 17, 2015
|
Yes please :)
|
JDutil
pushed a commit
to JDutil/spree
that referenced
this pull request
Mar 17, 2015
Fixes spree#6188 Conflicts: frontend/app/helpers/spree/frontend_helper.rb
JDutil
pushed a commit
to JDutil/spree
that referenced
this pull request
Mar 17, 2015
Fixes spree#6188 Conflicts: frontend/app/helpers/spree/frontend_helper.rb
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.